Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(renderer): pass field property to when in sequence and not #1423

Merged
merged 1 commit into from
Nov 6, 2023

Conversation

rvsia
Copy link
Contributor

@rvsia rvsia commented Nov 6, 2023

Fixes #1422

Description

field is not passed to inner sequence and not conditions

@rvsia rvsia added bug Something isn't working renderer React form renderer PR labels Nov 6, 2023
@rvsia rvsia requested a review from Hyperkid123 November 6, 2023 14:18
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-forms ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 6, 2023 2:23pm

@DataDrivenFormsBot
Copy link

A new version (fix) will be released: v3.21.10 [DataDrivenFormsBot]

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Merging #1423 (31bb391) into master (208c9a2) will not change coverage.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1423   +/-   ##
=======================================
  Coverage   94.96%   94.96%           
=======================================
  Files         210      210           
  Lines        3672     3672           
  Branches     1284     1284           
=======================================
  Hits         3487     3487           
  Misses        185      185           
Files Coverage Δ
...rm-renderer/src/parse-condition/parse-condition.js 98.21% <100.00%> (ø)

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@rvsia rvsia merged commit b8c41c5 into data-driven-forms:master Nov 6, 2023
5 checks passed
@rvsia rvsia added the released label Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released renderer React form renderer PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When function in sequence called with undefined field
3 participants